CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

add_subscriptons_backend: Some minor code cleanup.

Browse Source 
(imported from commit 14a8352b65859b5a8688a6823404f4a7982403ae)
This commit is contained in:
Tim Abbott 2012-11-16 16:27:32 -05:00
parent f1ccf44c99
commit ff2b5c19de
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
zephyr/views.py
View File

@ -738,27 +738,25 @@ def add_subscriptions_backend(request, user_profile,
if not isinstance(streams_raw, list):
return json_error("'subscriptions' argument must be a list")
streams = []
stream_names = []
for stream_name in streams_raw:
stream_name = stream_name.strip()
if len(stream_name) > 30:
return json_error("Stream name (%s) too long." % (stream_name,))
if not valid_stream_name(stream_name):
return json_error("Invalid stream name (%s)." % (stream_name,))
streams.append(stream_name)
stream_names.append(stream_name)
subscribed = []
already_subscribed = []
for stream_name in set(streams):
result = dict(subscribed=[], already_subscribed=[])
for stream_name in set(stream_names):
stream = create_stream_if_needed(user_profile.realm, stream_name)
did_subscribe = do_add_subscription(user_profile, stream)
if did_subscribe:
subscribed.append(stream_name)
result["subscribed"].append(stream_name)
else:
already_subscribed.append(stream_name)
result["already_subscribed"].append(stream_name)
return json_success({"subscribed": subscribed,
"already_subscribed": already_subscribed})
return json_success(result)
@authenticated_json_view
@has_request_variables