CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

login: Clean up CSS/HTML for google/github login buttons.

Browse Source 
This removes some unnecessary code duplication in the CSS classes for
Google and GitHub authentication social auth buttons.

This will, in turn, help us avoid extra work every time we add a new
authentication backend.
This commit is contained in:
Tim Abbott 2018-10-11 16:52:00 -07:00
parent b51633efb7
commit fd4c23e12d
4 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static/styles/portico-signin.scss
View File

@ -582,10 +582,6 @@ html {
padding: 0 5px;
}
.login-google {
margin-bottom: 10px;
}
button.login-social-button {
width: 328px;
padding-left: 35px;

4
static/styles/portico.scss
View File

@ -1264,10 +1264,8 @@ input.new-organization-button {
font-weight: 300;
}
.login-google,
.register-google,
.login-sso,
.login-github {
.login-social {
max-width: 100%;
min-width: 300px;
margin: auto;

4
templates/zerver/accounts_home.html
View File

@ -76,7 +76,7 @@ $(function () {
{% endif %}
{% if google_auth_enabled %}
<div class="register-google">
<div class="login-social">
<form class="form-inline" action="{{ url('zerver.views.auth.start_google_oauth2') }}" method="get">
<input type='hidden' name='is_signup' value='1' />
<button class="login-social-button login-google-button full-width">
@ -87,7 +87,7 @@ $(function () {
{% endif %}
{% if github_auth_enabled %}
<div class="login-github">
<div class="login-social">
<form class="form-inline github-wrapper" action="{{ url('signup-social', args=('github',)) }}" method="get">
<button class="login-social-button login-github-button full-width">
{{ _('Sign up with %(identity_provider)s', identity_provider="GitHub") }}

4
templates/zerver/login.html
View File

@ -133,7 +133,7 @@
{% endif %} <!-- if password_auth_enabled -->
{% if google_auth_enabled %}
<div class="login-google">
<div class="login-social">
<form id='google_login_form' class="form-inline" action="{{ url('zerver.views.auth.start_google_oauth2') }}" method="get">
<input type="hidden" name="next" value="{{ next }}">
<button class="login-social-button login-google-button full-width">
@ -144,7 +144,7 @@
{% endif %}
{% if github_auth_enabled %}
<div class="login-github">
<div class="login-social">
<form id='social_login_form' class="form-inline github-wrapper" action="{{ url('login-social', args=('github',)) }}" method="get">
<input type="hidden" name="next" value="{{ next }}">
<button class="login-social-button login-github-button github">