CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-15 21:03:26 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

popover: Rename keyboard handling functions for message user popovers.

Browse Source 
We rename user_info_popover_handle_keyboard and get_user_info_popover_items
to user_info_popover_for_message_handle_keyboard and
get_user_info_popover_for_message items to differentiate it from functions
that will be added for bot-owner popovers.
This commit is contained in:
sahil839 2020-09-19 22:01:41 +05:30 committed by Tim Abbott
parent 66ce8903d3
commit fc8ceceb1d
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/hotkey.js
View File

@ -575,7 +575,7 @@ exports.process_hotkey = function (e, hotkey) {
}
if (popovers.message_info_popped()) {
popovers.user_info_popover_handle_keyboard(event_name);
popovers.user_info_popover_for_message_handle_keyboard(event_name);
return true;
}

8
static/js/popovers.js
View File

@ -349,7 +349,7 @@ exports.show_user_profile = function (user) {
);
};
function get_user_info_popover_items() {
function get_user_info_popover_for_message_items() {
if (!current_message_info_popover_elem) {
blueslip.error("Trying to get menu items when action popover is closed.");
return;
@ -687,7 +687,7 @@ exports.hide_user_sidebar_popover = function () {
function focus_user_info_popover_item() {
// For now I recommend only calling this when the user opens the menu with a hotkey.
// Our popup menus act kind of funny when you mix keyboard and mouse.
const items = get_user_info_popover_items();
const items = get_user_info_popover_for_message_items();
exports.focus_first_popover_item(items);
}
@ -705,8 +705,8 @@ exports.user_sidebar_popover_handle_keyboard = function (key) {
exports.popover_items_handle_keyboard(key, items);
};
exports.user_info_popover_handle_keyboard = function (key) {
const items = get_user_info_popover_items();
exports.user_info_popover_for_message_handle_keyboard = function (key) {
const items = get_user_info_popover_for_message_items();
exports.popover_items_handle_keyboard(key, items);
};