CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

search: Fix bug preventing closing regular search pills.

Browse Source 
In an earlier refactor, `removePill` was being called with the exit
button element instead of the pill. This change fixes that bug by
using similar code to what we previously did (and still do in
input_pill for cases without on_pill_exit).
This commit is contained in:
evykassirer 2024-08-14 16:13:28 -07:00 committed by Tim Abbott
parent c0ac38fe8a
commit fc2ce3deb2
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/search_pill.ts
View File

@ -65,21 +65,22 @@ export function get_search_string_from_item(item: SearchPill): string {
// to e.g. remove a user from a group-DM pill without deleting the whole
// DM pill.
function on_pill_exit(
clicked_pill: HTMLElement,
clicked_element: HTMLElement,
all_pills: InputPill<SearchPill>[],
remove_pill: (pill: HTMLElement) => void,
): void {
const $user_pill_container = $(clicked_pill).parents(".user-pill-container");
const $user_pill_container = $(clicked_element).parents(".user-pill-container");
if (!$user_pill_container.length) {
// This is just a regular search pill, so we don't need to do fancy logic.
remove_pill(clicked_pill);
const $clicked_pill = $(clicked_element).closest(".pill");
remove_pill($clicked_pill[0]!);
return;
}
// The user-pill-container container class is used exclusively for
// group-DM search pills, where multiple user pills sit inside a larger
// pill. The exit icons in those individual user pills should remove
// just that pill, not the outer pill.
const user_id_string = $(clicked_pill).closest(".pill").attr("data-user-id");
const user_id_string = $(clicked_element).closest(".pill").attr("data-user-id");
assert(user_id_string !== undefined);
const user_id = Number.parseInt(user_id_string, 10);