From faf48d974f565e323dcf27bf7cb80273683c75f2 Mon Sep 17 00:00:00 2001
From: YashRE42 <33805964+YashRE42@users.noreply.github.com>
Date: Sat, 18 Apr 2020 15:39:26 +0530
Subject: [PATCH] navbar: Shift "search_icon" styles to be before tab_bar and
 search_box.

The motivation behind this change is that it is more sensible to have
search_icon styles appear first and then be overridden by
search_closed or search_open styles which appear afterwards. This is a
prep commit to correcting a bug that caused some browsers to
render the width (and hence margin and position) of search_closed
incorrectly.
---
 static/styles/zulip.scss | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/static/styles/zulip.scss b/static/styles/zulip.scss
index ed227d2769..32fd505a70 100644
--- a/static/styles/zulip.scss
+++ b/static/styles/zulip.scss
@@ -1371,6 +1371,20 @@ div.focused_table {
     border-left: 1px solid hsl(0, 0%, 88%);
 }
 
+
+.search_icon {
+    color: hsl(0, 0%, 80%);
+    text-decoration: none;
+    width: 0;
+    height: 0;
+    padding-top: 12px;
+    padding-left: 50px;
+    &:hover {
+        color: hsl(0, 0%, 0%);
+        text-decoration: none;
+    }
+}
+
 #tab_bar {
     width: 100%;
     z-index: 2;
@@ -1525,19 +1539,6 @@ div.focused_table {
     }
 }
 
-.search_icon {
-    color: hsl(0, 0%, 80%);
-    text-decoration: none;
-    width: 0;
-    height: 0;
-    padding-top: 12px;
-    padding-left: 50px;
-    &:hover {
-        color: hsl(0, 0%, 0%);
-        text-decoration: none;
-    }
-}
-
 #searchbox {
     display: flex;
     width: 100%;