From f8c3b70ced3ad50ca330c04695f4176793928a80 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Fri, 23 Aug 2013 13:03:09 -0400 Subject: [PATCH] Clarify Filter tests dealing with bogus operators (imported from commit db8327eb6df70bc8ffee7fb8166bc6491bd2fe70) --- zerver/tests/frontend/node/filter.js | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/zerver/tests/frontend/node/filter.js b/zerver/tests/frontend/node/filter.js index 18eeaedd6d..3e84dfdca9 100644 --- a/zerver/tests/frontend/node/filter.js +++ b/zerver/tests/frontend/node/filter.js @@ -97,10 +97,6 @@ var Filter = require('js/filter.js'); assert(!predicate({stream: 'unsub'})); assert(predicate({type: 'private'})); - // hack to get line coverage - predicate = get_predicate([['in', 'bogus']]); - predicate({}); - predicate = get_predicate([['near', 5]]); assert(predicate({})); @@ -132,6 +128,19 @@ var Filter = require('js/filter.js'); predicate = get_predicate(); assert(predicate({})); + + // Upstream code should prevent Filter.predicate from being called with + // invalid operator/operand combinations, but right now we just silently + // return a function that accepts all messages. + predicate = get_predicate([['in', 'bogus']]); + assert(predicate({})); + + predicate = get_predicate([['bogus', 33]]); + assert(predicate({})); + + predicate = get_predicate([['is', 'bogus']]); + assert(predicate({})); + }()); (function test_parse_and_unparse() {