diff --git a/web/src/settings_components.ts b/web/src/settings_components.ts index 53423fd383..805e307efc 100644 --- a/web/src/settings_components.ts +++ b/web/src/settings_components.ts @@ -1784,8 +1784,7 @@ export function create_stream_group_setting_widget({ if (sub !== undefined) { set_group_setting_widget_value(pill_widget, sub[setting_name]); - const $edit_container = stream_settings_containers.get_edit_container(sub); - const $subsection = $edit_container.find(".advanced-configurations-container"); + const $subsection = $pill_container.closest(".settings-subsection-parent"); pill_widget.onTextInputHook(() => { save_discard_stream_settings_widget_status_handler($subsection, sub); diff --git a/web/templates/stream_settings/stream_types.hbs b/web/templates/stream_settings/stream_types.hbs index 48709b8b4f..dfa1f840c5 100644 --- a/web/templates/stream_settings/stream_types.hbs +++ b/web/templates/stream_settings/stream_types.hbs @@ -82,89 +82,120 @@
-

{{t 'Advanced configuration' }}

+

{{t 'Advanced configuration' }}

- {{#if is_stream_edit}} - {{> ../settings/settings_save_discard_widget section_name="stream-permissions" }} - {{/if}}
-
- {{t 'Organization administrators can automatically administer all channels.'}} +
+
+

{{t "Subscription permissions"}}

+ {{#if is_stream_edit}} + {{> ../settings/settings_save_discard_widget section_name="subscription-permissions"}} + {{/if}} +
+ + {{> ../settings/group_setting_value_pill_input + setting_name="can_subscribe_group" + label=group_setting_labels.can_subscribe_group + prefix=prefix }} + + {{> ../settings/group_setting_value_pill_input + setting_name="can_add_subscribers_group" + label=group_setting_labels.can_add_subscribers_group + prefix=prefix }} + + {{> ../settings/group_setting_value_pill_input + setting_name="can_remove_subscribers_group" + label=group_setting_labels.can_remove_subscribers_group + prefix=prefix }}
- {{> ../settings/group_setting_value_pill_input - setting_name="can_subscribe_group" - label=group_setting_labels.can_subscribe_group - prefix=prefix }} +
+
+

{{t "Messaging permissions"}}

+ {{#if is_stream_edit}} + {{> ../settings/settings_save_discard_widget section_name="messaging-permissions"}} + {{/if}} +
- {{> ../settings/group_setting_value_pill_input - setting_name="can_add_subscribers_group" - label=group_setting_labels.can_add_subscribers_group - prefix=prefix }} + {{> ../settings/group_setting_value_pill_input + setting_name="can_send_message_group" + label=group_setting_labels.can_send_message_group + prefix=prefix + help_link="/help/stream-sending-policy" }} - {{> ../settings/group_setting_value_pill_input - setting_name="can_remove_subscribers_group" - label=group_setting_labels.can_remove_subscribers_group - prefix=prefix }} - - {{> ../settings/group_setting_value_pill_input - setting_name="can_send_message_group" - label=group_setting_labels.can_send_message_group - prefix=prefix - help_link="/help/stream-sending-policy" }} - -
- - +
+ + +
- {{> ../settings/group_setting_value_pill_input - setting_name="can_move_messages_within_channel_group" - label=group_setting_labels.can_move_messages_within_channel_group - prefix=prefix }} +
+
+

{{t "Moderation permissions"}}

+ {{#if is_stream_edit}} + {{> ../settings/settings_save_discard_widget section_name="moderation-permissions"}} + {{/if}} +
- {{> ../settings/group_setting_value_pill_input - setting_name="can_move_messages_out_of_channel_group" - label=group_setting_labels.can_move_messages_out_of_channel_group - prefix=prefix }} + {{> ../settings/group_setting_value_pill_input + setting_name="can_move_messages_within_channel_group" + label=group_setting_labels.can_move_messages_within_channel_group + prefix=prefix }} - {{> ../settings/group_setting_value_pill_input - setting_name="can_administer_channel_group" - label=group_setting_labels.can_administer_channel_group - prefix=prefix }} + {{> ../settings/group_setting_value_pill_input + setting_name="can_move_messages_out_of_channel_group" + label=group_setting_labels.can_move_messages_out_of_channel_group + prefix=prefix }} +
- {{#if (or is_owner is_stream_edit)}} -
-
- +
+
+

{{t "Administrative permissions"}}

+ {{#if is_stream_edit}} + {{> ../settings/settings_save_discard_widget section_name="administrative-permissions"}} + {{/if}} +
+
+ {{t 'Organization administrators can automatically administer all channels.'}} +
+ {{> ../settings/group_setting_value_pill_input + setting_name="can_administer_channel_group" + label=group_setting_labels.can_administer_channel_group + prefix=prefix }} - {{> ../settings/upgrade_tip_widget .}} - - - -
-
- {{/if}} + {{/if}} +