From f49980098d69591a968b53145a6f4036c995a489 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Tue, 9 Nov 2021 18:47:09 +0530
Subject: [PATCH] settings: Fix live update code for twenty_four_hour_time
 setting.

We need to handle live-update of twenty_four_hour_time setting
separately in update_page because the database value of this
setting is boolean but we use dropdown in the frontend for this
setting with option values as "true" and "false" strings.
---
 static/js/settings_realm_user_settings_defaults.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/static/js/settings_realm_user_settings_defaults.js b/static/js/settings_realm_user_settings_defaults.js
index c8f4422b68..ada7415055 100644
--- a/static/js/settings_realm_user_settings_defaults.js
+++ b/static/js/settings_realm_user_settings_defaults.js
@@ -26,12 +26,16 @@ export function update_page(property) {
         return;
     }
     const container = $(realm_default_settings_panel.container);
-    const value = realm_user_settings_defaults[property];
+    let value = realm_user_settings_defaults[property];
 
     if (property === "emojiset") {
         container.find(`input[value=${CSS.escape(value)}]`).prop("checked", true);
         return;
     }
+    if (property === "twenty_four_hour_time") {
+        value = value.toString();
+    }
+
     const input_elem = container.find(`[name=${CSS.escape(property)}]`);
     settings_org.set_input_element_value(input_elem, value);
 }