From f38fe78e53af6822b8f9fb7f547775eed4e54dbb Mon Sep 17 00:00:00 2001 From: Shubham Padia Date: Fri, 30 Aug 2024 10:50:29 +0000 Subject: [PATCH] css: Use classnames for settings page .sidebar li items. Having the > ul selector there affects the performance. See https://chat.zulip.org/#narrow/stream/6-frontend/topic/CSS.20selector.20performance/near/1845719 for more details. --- web/styles/settings.css | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/web/styles/settings.css b/web/styles/settings.css index e6cd56dd0e..1c1a4d1f04 100644 --- a/web/styles/settings.css +++ b/web/styles/settings.css @@ -1419,12 +1419,6 @@ $option_title_width: 180px; border-bottom: 1px solid hsl(0deg 0% 87%); } - & ul { - list-style: none; - margin: 0; - padding: 0; - } - .sidebar-item { display: grid; /* 3.5714em is 50px at 14px/1em -- the legacy height of these rows. */ @@ -1484,6 +1478,9 @@ $option_title_width: 180px; .normal-settings-list, .org-settings-list { position: relative; + list-style: none; + margin: 0; + padding: 0; } }