From efc1c74792aa5ee3a2016f61afc88d0469bf3194 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Sat, 5 Jan 2019 16:08:53 +0000 Subject: [PATCH] message scrolling: Move early-exit code higher. This avoids some unnecessary computation and will simplify testing. --- static/js/message_list_view.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/static/js/message_list_view.js b/static/js/message_list_view.js index c38f158a1d..ba8eda207f 100644 --- a/static/js/message_list_view.js +++ b/static/js/message_list_view.js @@ -804,9 +804,6 @@ MessageListView.prototype = { return; } - var info = message_viewport.message_viewport_info(); - var scroll_limit = this._scroll_limit(selected_row, info); - if (new_messages_height <= 0) { return; } @@ -827,6 +824,9 @@ MessageListView.prototype = { return; } + var info = message_viewport.message_viewport_info(); + var scroll_limit = this._scroll_limit(selected_row, info); + // This next decision is fairly debatable. For a big message that // would push the pointer off the screen, we do a partial autoscroll, // which has the following implications: