diff --git a/static/images/integrations/newrelic/001.png b/static/images/integrations/newrelic/001.png deleted file mode 100644 index f34b95d2fb..0000000000 Binary files a/static/images/integrations/newrelic/001.png and /dev/null differ diff --git a/static/images/integrations/newrelic/ack.png b/static/images/integrations/newrelic/ack.png new file mode 100644 index 0000000000..b0f254a904 Binary files /dev/null and b/static/images/integrations/newrelic/ack.png differ diff --git a/static/images/integrations/newrelic/closed.png b/static/images/integrations/newrelic/closed.png new file mode 100644 index 0000000000..d5af210c6a Binary files /dev/null and b/static/images/integrations/newrelic/closed.png differ diff --git a/static/images/integrations/newrelic/newrelic.png b/static/images/integrations/newrelic/newrelic.png new file mode 100644 index 0000000000..2691df1b31 Binary files /dev/null and b/static/images/integrations/newrelic/newrelic.png differ diff --git a/static/images/integrations/newrelic/opened.png b/static/images/integrations/newrelic/opened.png new file mode 100644 index 0000000000..e55b6c0b78 Binary files /dev/null and b/static/images/integrations/newrelic/opened.png differ diff --git a/zerver/webhooks/newrelic/doc.md b/zerver/webhooks/newrelic/doc.md index 3482dc2fb6..44eb790e21 100644 --- a/zerver/webhooks/newrelic/doc.md +++ b/zerver/webhooks/newrelic/doc.md @@ -1,16 +1,25 @@ -New Relic can send messages to a Zulip stream for alerts and -deploys. +New Relic can send messages to a Zulip stream for incidents. -{!create-stream.md!} +1. {!create-stream.md!} -{!create-bot-construct-url.md!} +1. {!create-bot-construct-url-indented.md!} -Next, in your New Relic Account Settings page, click -**Integrations**, then **Alerting notifications**. On the -**Webhook** tab, enter the webhook URL created earlier: +1. On [New Relic](https://one.newrelic.com), + select **Alerts & AI**. -![](/static/images/integrations/newrelic/001.png) +1. Navigate to **Notification channels**. + +1. Create a new notification channel. Select channel type of **Webhook**, choose a name (e.g. "Zulip"), enter the webhook url created earlier as **Base Url**. + +1. It should look like: + ![](/static/images/integrations/newrelic/newrelic.png) + +1. The webhook works with the default payload, click **Create channel**. + +1. After creating the channel send a test notification to make sure it works. {!congrats.md!} -![](/static/images/integrations/newrelic/002.png) +![](/static/images/integrations/newrelic/opened.png) +![](/static/images/integrations/newrelic/ack.png) +![](/static/images/integrations/newrelic/closed.png) diff --git a/zerver/webhooks/newrelic/tests.py b/zerver/webhooks/newrelic/tests.py index 2f23317968..df06ded44e 100644 --- a/zerver/webhooks/newrelic/tests.py +++ b/zerver/webhooks/newrelic/tests.py @@ -84,16 +84,6 @@ No details. ) self.assertIn("The newrelic webhook requires current_state be in [open|acknowledged|closed]", e.exception.args[0]) - def test_missing_duration(self) -> None: - with self.assertRaises(AssertionError) as e: - self.check_webhook( - "incident_missing_duration", - "", - "", - content_type="application/json", - ) - self.assertIn("The newrelic webhook requires duration in milliseconds", e.exception.args[0]) - def test_missing_timestamp(self) -> None: with self.assertRaises(AssertionError) as e: self.check_webhook(