CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-15 21:03:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid scrolling when rendering a new portion of the message list

Browse Source 
(imported from commit f8a2f8ee13b20187df179d41dea5cc14de24e797)
This commit is contained in:
Zev Benjamin 2013-03-04 14:22:09 -05:00
parent 182eb86db7
commit ebabe0caeb
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
zephyr/static/js/message_list.js
View File

@ -105,11 +105,23 @@ MessageList.prototype = {
}
}
this._selected_id = id;
// This is the number of pixels between the top of the
// viewable window and the newly selected message
var scrolltop_offset;
var selected_row = rows.get(id, this.table_name);
var new_msg_in_view = (selected_row.length > 0);
if (new_msg_in_view) {
scrolltop_offset = viewport.scrollTop() - selected_row.offset().top;
}
if (this._maybe_rerender()) {
// We need to scroll because the message list was
// rerendered and the new message may no longer be on the
// screen
opts.then_scroll = true;
// If we could see the newly selected message, scroll the
// window such that the newly selected message is at the
// same location as it would have been before we
// re-rendered.
if (new_msg_in_view) {
viewport.scrollTop(rows.get(id, this.table_name).offset().top + scrolltop_offset);
}
}
$(document).trigger($.Event('message_selected.zephyr', opts));
},