From ea2e5de54fc32779a72dc2f0fe11f041846fe5cc Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Wed, 3 Mar 2021 13:05:19 -0800 Subject: [PATCH] requirements: Downgrade jedi dependency for ipython compatibility. ipython < 7.20.0 is incompatible with jedi >= 0.18.0; it fails to tab-complete in `./manage.py shell`, as described in ipython/ipython#12740. We cannot bump the ipython dependency because ipython 7.20.0 requires Python 3.7, and we must support Python 3.6 due to Ubuntu 18.04 support. Our only solution is thus to cap the version of `jedi` to the last one before its API changed. --- requirements/common.in | 5 +++++ requirements/dev.txt | 16 +++++++++------- requirements/prod.txt | 16 +++++++++------- version.py | 2 +- 4 files changed, 24 insertions(+), 15 deletions(-) diff --git a/requirements/common.in b/requirements/common.in index 9f559111df..fe332eeeb9 100644 --- a/requirements/common.in +++ b/requirements/common.in @@ -23,6 +23,11 @@ jsx-lexer # Needed for manage.py ipython +# Needed for compatibility with ipython < 7.20, which we cannot +# install on Python <3.7; see +# https://github.com/ipython/ipython/issues/12740 +jedi<0.18.0 + # Needed for image processing Pillow diff --git a/requirements/dev.txt b/requirements/dev.txt index 9f557a36e9..892e20ec97 100644 --- a/requirements/dev.txt +++ b/requirements/dev.txt @@ -558,10 +558,12 @@ itemloaders==1.0.4 \ --hash=sha256:1277cd8ca3e4c02dcdfbc1bcae9134ad89acfa6041bd15b4561c6290203a0c96 \ --hash=sha256:4cb46a0f8915e910c770242ae3b60b1149913ed37162804f1e40e8535d6ec497 # via scrapy -jedi==0.18.0 \ - --hash=sha256:18456d83f65f400ab0c2d3319e48520420ef43b23a086fdc05dff34132f0fb93 \ - --hash=sha256:92550a404bad8afed881a137ec9a461fed49eca661414be45059329614ed0707 - # via ipython +jedi==0.17.2 \ + --hash=sha256:86ed7d9b750603e4ba582ea8edc678657fb4007894a12bcf6f4bb97892f31d20 \ + --hash=sha256:98cc583fa0f2f8304968199b01b6b4b94f469a1f4a74c1560506ca2a211378b5 + # via + # -r requirements/common.in + # ipython jinja2==2.11.3 \ --hash=sha256:03e47ad063331dd6a3f04a43eddca8a966a26ba0c5b7207a9a9e4e08f1b29419 \ --hash=sha256:a6d58433de0ae800347cab1fa3043cebbabe8baa9d29e668f1c768cb87a333c6 @@ -880,9 +882,9 @@ parsel==1.6.0 \ # via # itemloaders # scrapy -parso==0.8.1 \ - --hash=sha256:15b00182f472319383252c18d5913b69269590616c947747bc50bf4ac768f410 \ - --hash=sha256:8519430ad07087d4c997fda3a7918f7cfa27cb58972a8c89c2a0295a1c940e9e +parso==0.7.1 \ + --hash=sha256:97218d9159b2520ff45eb78028ba8b50d2bc61dcc062a9682666f2dc4bd331ea \ + --hash=sha256:caba44724b994a8a5e086460bb212abc5a8bc46951bf4a9a1210745953622eb9 # via jedi pathspec==0.8.1 \ --hash=sha256:86379d6b86d75816baba717e64b1a3a3469deb93bb76d613c9ce79edc5cb68fd \ diff --git a/requirements/prod.txt b/requirements/prod.txt index 9865dec553..628e1b2e44 100644 --- a/requirements/prod.txt +++ b/requirements/prod.txt @@ -378,10 +378,12 @@ isodate==0.6.0 \ # openapi-core # openapi-schema-validator # python3-saml -jedi==0.18.0 \ - --hash=sha256:18456d83f65f400ab0c2d3319e48520420ef43b23a086fdc05dff34132f0fb93 \ - --hash=sha256:92550a404bad8afed881a137ec9a461fed49eca661414be45059329614ed0707 - # via ipython +jedi==0.17.2 \ + --hash=sha256:86ed7d9b750603e4ba582ea8edc678657fb4007894a12bcf6f4bb97892f31d20 \ + --hash=sha256:98cc583fa0f2f8304968199b01b6b4b94f469a1f4a74c1560506ca2a211378b5 + # via + # -r requirements/common.in + # ipython jinja2==2.11.3 \ --hash=sha256:03e47ad063331dd6a3f04a43eddca8a966a26ba0c5b7207a9a9e4e08f1b29419 \ --hash=sha256:a6d58433de0ae800347cab1fa3043cebbabe8baa9d29e668f1c768cb87a333c6 @@ -600,9 +602,9 @@ orjson==3.5.0 \ parse==1.19.0 \ --hash=sha256:9ff82852bcb65d139813e2a5197627a94966245c897796760a3a2a8eb66f020b # via openapi-core -parso==0.8.1 \ - --hash=sha256:15b00182f472319383252c18d5913b69269590616c947747bc50bf4ac768f410 \ - --hash=sha256:8519430ad07087d4c997fda3a7918f7cfa27cb58972a8c89c2a0295a1c940e9e +parso==0.7.1 \ + --hash=sha256:97218d9159b2520ff45eb78028ba8b50d2bc61dcc062a9682666f2dc4bd331ea \ + --hash=sha256:caba44724b994a8a5e086460bb212abc5a8bc46951bf4a9a1210745953622eb9 # via jedi pexpect==4.8.0 \ --hash=sha256:0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937 \ diff --git a/version.py b/version.py index 990843d344..75cdc80f7b 100644 --- a/version.py +++ b/version.py @@ -45,4 +45,4 @@ API_FEATURE_LEVEL = 40 # historical commits sharing the same major version, in which case a # minor version bump suffices. -PROVISION_VERSION = "131.0" +PROVISION_VERSION = "131.1"