From e8ab7cd1a9e2d3470c9580d501e489dd08f79806 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 27 Oct 2017 15:34:36 -0700 Subject: [PATCH] logging: Fix zulip.send_email log being printed in tests. Our set_loglevel tool didn't set propagate to False, so just using it directly wouldn't work unless the logger is explcitly declared in zproject/settings.py, which this one isn't. --- zproject/test_settings.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zproject/test_settings.py b/zproject/test_settings.py index d4fd0f6477..6129e50a3e 100644 --- a/zproject/test_settings.py +++ b/zproject/test_settings.py @@ -114,10 +114,12 @@ else: def set_loglevel(logger_name, level): LOGGING['loggers'].setdefault(logger_name, {})['level'] = level + LOGGING['loggers'].setdefault(logger_name, {})['propagate'] = False set_loglevel('zulip.requests', 'CRITICAL') set_loglevel('zulip.management', 'CRITICAL') set_loglevel('django.request', 'ERROR') set_loglevel('fakeldap', 'ERROR') + set_loglevel('zulip.send_email', 'ERROR') # Enable file:/// hyperlink support by default in tests ENABLE_FILE_LINKS = True