From e653bb2733db729480c09bb36dfacf5a5fb8ae08 Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Thu, 14 Jul 2022 17:35:51 -0700 Subject: [PATCH] rocketchat: Handle PMs with only one recipient. These are either to a deleted user, or actually to the same user. In any case, treat them as self-messages. --- zerver/data_import/rocketchat.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/zerver/data_import/rocketchat.py b/zerver/data_import/rocketchat.py index 38861adc65..ab15074e60 100644 --- a/zerver/data_import/rocketchat.py +++ b/zerver/data_import/rocketchat.py @@ -637,6 +637,10 @@ def process_messages( message_dict["recipient_id"] = huddle_id_to_recipient_id[huddle_id] else: rc_member_ids = direct_id_to_direct_map[rc_channel_id]["uids"] + + if len(rc_member_ids) == 1: # nocoverage + # PMs to yourself only have one user. + rc_member_ids.append(rc_member_ids[0]) if rc_sender_id == rc_member_ids[0]: zulip_member_id = user_id_mapper.get(rc_member_ids[1]) message_dict["recipient_id"] = user_id_to_recipient_id[zulip_member_id]