From e4bbfe5eb7fca6a295fc82af334444e68d9467cb Mon Sep 17 00:00:00 2001 From: Riken Shah Date: Tue, 18 May 2021 13:23:52 +0000 Subject: [PATCH] puppeteer_test: Add wait call for linkifier table to get updated. This commit solves a rare flake, where the `realm _linkifier.ts` test was failing because there was no appropriate wait call for the table (`#admin_linkifiers_table`) to get updated after editing the pattern. --- frontend_tests/puppeteer_tests/realm-linkifier.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/frontend_tests/puppeteer_tests/realm-linkifier.ts b/frontend_tests/puppeteer_tests/realm-linkifier.ts index 227d0134e3..0602ce3eb4 100644 --- a/frontend_tests/puppeteer_tests/realm-linkifier.ts +++ b/frontend_tests/puppeteer_tests/realm-linkifier.ts @@ -64,11 +64,9 @@ async function test_edit_linkifier(page: Page): Promise { await page.click(".submit-linkifier-info-change"); await page.waitForSelector("#linkifier-edit-form-modal", {hidden: true}); - await page.waitForFunction(() => $(".edit-linkifier-status").text().trim() === "Saved"); await page.waitForSelector(".linkifier_row", {visible: true}); - assert.strictEqual( - await common.get_text_from_selector(page, ".linkifier_row span.linkifier_pattern"), - "(?P[0-9a-f]{40})", + await page.waitForFunction( + () => document.querySelector(".linkifier_pattern")?.textContent === "(?P[0-9a-f]{40})", ); assert.strictEqual( await common.get_text_from_selector(