From e18d76f4dd59ea132acdfffc28db0ca04b4f333a Mon Sep 17 00:00:00 2001 From: Luke Faraone Date: Fri, 10 May 2013 15:15:57 -0700 Subject: [PATCH] Readd a default for enable_sounds in json_change_settings. Previously a default was missing from this function, which resulted in users being unable to change their settings if they tried to disable sounds. (imported from commit 2dae67dcb2e8cb986abb6dee9659be2192993dd9) --- zephyr/views.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zephyr/views.py b/zephyr/views.py index b2c8160d19..4a2997307c 100644 --- a/zephyr/views.py +++ b/zephyr/views.py @@ -1285,7 +1285,8 @@ def json_change_settings(request, user_profile, full_name=REQ, # because browsers POST nothing for an unchecked checkbox enable_desktop_notifications=REQ(converter=lambda x: x == "on", default=False), - enable_sounds=REQ(converter=lambda x: x == "on"), + enable_sounds=REQ(converter=lambda x: x == "on", + default=False), enable_offline_email_notifications=REQ(converter=lambda x: x == "on", default=False)): if new_password != "" or confirm_password != "":