From dc5095bad9ab9fa6930d0b29db7bc7d022e16403 Mon Sep 17 00:00:00 2001 From: Riken Shah Date: Wed, 3 Mar 2021 04:51:58 +0000 Subject: [PATCH] puppeteer_test: Add `waitForNavigation` when reloading. This commit ensures that it waits until the page is reloaded which avoids uncertain flake. --- frontend_tests/puppeteer_tests/07-navigation.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend_tests/puppeteer_tests/07-navigation.ts b/frontend_tests/puppeteer_tests/07-navigation.ts index b9c0770063..7be89c5a2e 100644 --- a/frontend_tests/puppeteer_tests/07-navigation.ts +++ b/frontend_tests/puppeteer_tests/07-navigation.ts @@ -58,6 +58,7 @@ async function test_reload_hash(page: Page): Promise { const initial_hash = await page.evaluate(() => window.location.hash); await page.evaluate(() => zulip_test.initiate_reload({immediate: true})); + await page.waitForNavigation(); await page.waitForSelector("#zfilt", {visible: true}); const page_load_time = await page.evaluate(() => page_params.page_load_time);