CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

report: Correct type annotation allowing unauth access.

Browse Source 
`report/error` is a path where we allow anonymous user access. This has
to be correctly denoted in the type annotation of the user argument of
the view function.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li 2022-07-19 10:47:18 -04:00 committed by Tim Abbott
parent 97fd662d48
commit da326aedff
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/views/report.py
View File

@ -119,7 +119,7 @@ def report_unnarrow_times(
@has_request_variables
def report_error(
request: HttpRequest,
user_profile: UserProfile,
maybe_user_profile: Union[AnonymousUser, UserProfile],
message: str = REQ(),
stacktrace: str = REQ(),
ui_message: bool = REQ(json_validator=check_bool),
@ -155,9 +155,9 @@ def report_error(
if more_info.get("draft_content"):
more_info["draft_content"] = privacy_clean_markdown(more_info["draft_content"])
if user_profile.is_authenticated:
email = user_profile.delivery_email
full_name = user_profile.full_name
if maybe_user_profile.is_authenticated:
email = maybe_user_profile.delivery_email
full_name = maybe_user_profile.full_name
else:
email = "unauthenticated@example.com"
full_name = "Anonymous User"