Make node tests have _ and Dict automatically as global vars.

Having to explicitly call out the underscore/Dict dependencies
in nearly every test has proven to be more cumbersome than helpful.
We never monkeypatch those modules in the tests.

(imported from commit 49ef70c835edd4e22a5869eda9235ef3ffc3c59b)

zerver/tests/frontend/node/activity.js

@@ -10,9 +10,7 @@ set_global('$', function () {
 $.fn = {};
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     util: 'js/util.js',
-    Dict: 'js/dict.js',
     people: 'js/people.js'
 });
 

zerver/tests/frontend/node/alert_words.js

@@ -1,9 +1,5 @@
 var assert = require('assert');
 
-add_dependencies({
-    _: 'third/underscore/underscore.js'
-});
-
 set_global('page_params', {
     alert_words: ['alertone', 'alerttwo', 'alertthree', 'al*rt.*s', '.+'],
     email: 'tester@zulip.com'

zerver/tests/frontend/node/composebox_typeahead.js

@@ -1,10 +1,5 @@
 var assert = require('assert');
 
-add_dependencies({
-    _: 'third/underscore/underscore.js',
-    Dict: 'js/dict.js'
-});
-
 var ct = require('js/composebox_typeahead.js');
 
 var people_in_realm = [{email: 'othello@zulip.com', full_name: "Othello, Moor of Venice"},

zerver/tests/frontend/node/dict.js

@@ -1,9 +1,6 @@
-add_dependencies({
-    _: 'third/underscore/underscore.js'
-});
-
 var _ = global._;
-var Dict = require('js/dict.js');
+var Dict = global.Dict;
+
 var assert = require('assert');
 
 set_global('blueslip', {});

zerver/tests/frontend/node/echo.js

@@ -6,9 +6,7 @@ var fs = require('fs');
 set_global('page_params', {realm_emoji: {}});
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     marked: 'third/marked/lib/marked.js',
-    Dict: 'js/dict.js',
     emoji: 'js/emoji.js',
     people: 'js/people.js',
     fenced_code: 'js/fenced_code.js'

zerver/tests/frontend/node/filter.js

@@ -1,9 +1,7 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     util: 'js/util.js',
-    Dict: 'js/dict.js',
     stream_data: 'js/stream_data.js'
 });
 

zerver/tests/frontend/node/index.js

@@ -1,7 +1,10 @@
 var fs = require('fs');
-var _ = require('third/underscore/underscore.js');
 var Handlebars = require('handlebars');
 
+global.Dict = require('js/dict');
+global._ = require('third/underscore/underscore.js');
+var _ = global._;
+
 // Run all the JS scripts in our test directory.  Tests do NOT run
 // in isolation.
 

zerver/tests/frontend/node/message_list.js

@@ -5,9 +5,7 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     util: 'js/util.js',
-    Dict: 'js/dict.js',
     muting: 'js/muting.js',
     MessageListView: 'js/message_list_view.js'
 });

zerver/tests/frontend/node/muting.js

@@ -1,10 +1,5 @@
 var assert = require('assert');
 
-add_dependencies({
-    _: 'third/underscore/underscore.js',
-    Dict: 'js/dict.js'
-});
-
 set_global('page_params', {
     domain: 'zulip.com'
 });

zerver/tests/frontend/node/narrow.js

@@ -1,8 +1,6 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
-    Dict: 'js/dict.js',
     stream_data: 'js/stream_data.js',
     Filter: 'js/filter.js'
 });

zerver/tests/frontend/node/search_suggestion.js

@@ -8,9 +8,7 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     util: 'js/util.js',
-    Dict: 'js/dict.js',
     Handlebars: 'handlebars',
     Filter: 'js/filter.js',
     typeahead_helper: 'js/typeahead_helper.js',

zerver/tests/frontend/node/stream_color.js

@@ -1,9 +1,5 @@
 var assert = require('assert');
 
-add_dependencies({
-    _: 'third/underscore/underscore.js'
-});
-
 set_global('$', function (f) {});
 
 var stream_color = require('js/stream_color.js');

zerver/tests/frontend/node/stream_data.js

@@ -1,8 +1,6 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
-    Dict: 'js/dict.js',
     stream_color: 'js/stream_color.js'
 });
 

zerver/tests/frontend/node/stream_list.js

@@ -3,8 +3,6 @@ var assert = require('assert');
 set_global('$', function () {});
 
 add_dependencies({
-    _: 'third/underscore/underscore',
-    Dict: 'js/dict',
     Handlebars: 'handlebars',
     templates: 'js/templates',
     muting: 'js/muting',

zerver/tests/frontend/node/templates.js

@@ -2,7 +2,6 @@ var assert = require('assert');
 
 add_dependencies({
     Handlebars: 'handlebars',
-    _: 'third/underscore/underscore',
     templates: 'js/templates'
 });
 

zerver/tests/frontend/node/unread.js

@@ -8,9 +8,7 @@
 // dependencies (except _).
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
-    muting: 'js/muting.js',
-    Dict: 'js/dict.js'
+    muting: 'js/muting.js'
 });
 
 var stream_data = require('js/stream_data.js');

zerver/tests/frontend/node/util.js

@@ -1,7 +1,6 @@
 var assert = require('assert');
 
 add_dependencies({
-    _: 'third/underscore/underscore.js',
     util: 'js/util.js'
 });