From d4a4e2df3abd52ddd24f8b36ecf1857bc6b1ea5d Mon Sep 17 00:00:00 2001 From: Lalit Date: Sat, 20 Jan 2024 14:48:13 +0530 Subject: [PATCH] message_viewport: Modify parameters for dimension wrapper functions. JQuery's `height` and `width` methods only takes one argument in case we want to set height or width. The argument is of type `string` or `number` or a function. Refrence: https://api.jquery.com/height/#height-value. Therefore, we can get rid of argument array and just accept a single argument in the inner function in `make_dim_wrapper`. --- web/src/message_viewport.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/src/message_viewport.js b/web/src/message_viewport.js index 31a2135d9b..cb822986c7 100644 --- a/web/src/message_viewport.js +++ b/web/src/message_viewport.js @@ -18,10 +18,10 @@ function make_dimen_wrapper(dimen_name, dimen_func) { return dimen_func(); }, }); - return function viewport_dimension_wrapper(...args) { - if (args.length !== 0) { + return function viewport_dimension_wrapper(val) { + if (val !== undefined) { dimensions[dimen_name].reset(); - return dimen_func(...args); + return dimen_func(val); } return dimensions[dimen_name].get(); };