From c8d043e12cef7eb42babde6da18eea07d5e8c229 Mon Sep 17 00:00:00 2001 From: Joseph Ho <62449508+Joelute@users.noreply.github.com> Date: Tue, 21 Mar 2023 15:47:47 -0400 Subject: [PATCH] popovers: Fix tooltip partially hidden by recipient bar when selected. Previously, when a user view the message source of a message at the very top with the blue box around, the tooltip for the button will be partially hidden by the recipient bar. Ths cause is some legacy CSS from, for example, 3cd33c0fea74b8f0524680a4b1ba8b4622b79033, which increased the z-index for the bodies of selected messages. The intent of that code appeared to be something around handling overlaps between unread indicators and the blue selected message box. It's logically incorrect, and testing demonstrates that the blue box works fine next to unread messages without this change, so we can safely remove these z-index values. --- web/styles/zulip.css | 8 -------- 1 file changed, 8 deletions(-) diff --git a/web/styles/zulip.css b/web/styles/zulip.css index d9add62d16..dd9a85f6fe 100644 --- a/web/styles/zulip.css +++ b/web/styles/zulip.css @@ -1361,10 +1361,6 @@ td.pointer { } .selected_message { - .messagebox { - z-index: 1; - } - .messagebox-content { box-shadow: inset 0 0 0 2px hsl(215, 47%, 50%), 0 0 0 1px hsl(215, 47%, 50%); @@ -1479,10 +1475,6 @@ div.message_table { border-left: 1px solid hsla(0, 0%, 0%, 0.1); border-right: 1px solid hsla(0, 0%, 0%, 0.1); - &.selected_message { - z-index: 2; - } - .date_row { /* We only want padding for the date rows between recipient blocks */ padding-bottom: 0;