diff --git a/tools/test-install/destroy-all b/tools/test-install/destroy-all index 5deed5a8a8..cfb6cf950d 100755 --- a/tools/test-install/destroy-all +++ b/tools/test-install/destroy-all @@ -28,7 +28,7 @@ fi lxc-ls -f \ | perl -lane '$_ = $F[0]; print if (/^zulip-install-/ && !/-base$/)' \ - | while read c + | while read -r c do echo "$c" lxc-stop -n "$c" diff --git a/tools/test-install/install b/tools/test-install/install index cc62dc7d41..187633eea2 100755 --- a/tools/test-install/install +++ b/tools/test-install/install @@ -54,7 +54,7 @@ EOF trap 'set +x; echo "$message"' EXIT if [ -d "$INSTALLER" ]; then - installer_dir="$(readlink -f $INSTALLER)" + installer_dir="$(readlink -f "$INSTALLER")" else installer_dir="$(mktemp -d --tmpdir zulip-server-XXXXX)" tar -xf "$INSTALLER" -C "$installer_dir" --transform='s,^[^/]*,zulip-server,' diff --git a/tools/test-install/lxc-wait b/tools/test-install/lxc-wait index ccebe8b3cd..b03e300c9d 100755 --- a/tools/test-install/lxc-wait +++ b/tools/test-install/lxc-wait @@ -27,7 +27,7 @@ if [ "$EUID" -ne 0 ]; then fi # We poll. -for i in {1..60}; do +for _ in {1..60}; do echo "lxc-wait: $CONTAINER_NAME: polling for boot..." >&2 runlevel="$(lxc-attach -n "$CONTAINER_NAME" -- runlevel 2>/dev/null)" \ || { sleep 1; continue; }