CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

group_permission_settings: Use set instead of list.

Browse Source 
check_group_permission_settings_data now uses set for the
list of settings defined in data structures in settings_config
which makes the code little efficient when checking if the
data structure contains all the setting names or not.
This commit is contained in:
Sahil Batra 2025-02-04 13:33:41 +05:30 committed by Tim Abbott
parent 0f1621c88f
commit bec0326776
1 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
web/src/group_permission_settings.ts
View File

@ -238,28 +238,28 @@ export function check_group_permission_settings_data(): void {
const all_realm_group_settings = z
.array(realm_group_setting_name_schema)
.parse(Object.keys(realm.server_supported_permission_settings.realm));
const realm_group_settings_with_subsection_data: RealmGroupSettingName[] = [];
const realm_group_settings_with_subsection_data = new Set<RealmGroupSettingName>([]);
for (const subsection_obj of settings_config.realm_group_permission_settings) {
for (const setting_name of subsection_obj.settings) {
realm_group_settings_with_subsection_data.push(setting_name);
realm_group_settings_with_subsection_data.add(setting_name);
}
}
if (
!all_realm_group_settings.every((setting_name) =>
realm_group_settings_with_subsection_data.includes(setting_name),
realm_group_settings_with_subsection_data.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.realm_group_permission_settings'");
return;
}
const realm_group_setting_label_object_keys = Object.keys(
settings_config.all_group_setting_labels.realm,
const realm_group_setting_label_object_keys = new Set(
Object.keys(settings_config.all_group_setting_labels.realm),
);
if (
!all_realm_group_settings.every((setting_name) =>
realm_group_setting_label_object_keys.includes(setting_name),
realm_group_setting_label_object_keys.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.all_group_setting_labels.realm'");
@ -269,21 +269,24 @@ export function check_group_permission_settings_data(): void {
const all_stream_group_settings = z
.array(stream_group_setting_name_schema)
.parse(Object.keys(realm.server_supported_permission_settings.stream));
const stream_group_permission_settings = new Set(
settings_config.stream_group_permission_settings,
);
if (
!all_stream_group_settings.every((setting_name) =>
settings_config.stream_group_permission_settings.includes(setting_name),
stream_group_permission_settings.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.stream_group_permission_settings'");
return;
}
const stream_group_setting_label_object_keys = Object.keys(
settings_config.all_group_setting_labels.stream,
const stream_group_setting_label_object_keys = new Set(
Object.keys(settings_config.all_group_setting_labels.stream),
);
if (
!all_stream_group_settings.every((setting_name) =>
stream_group_setting_label_object_keys.includes(setting_name),
stream_group_setting_label_object_keys.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.all_group_setting_labels.stream'");
@ -291,21 +294,22 @@ export function check_group_permission_settings_data(): void {
}
const all_group_group_settings = get_group_permission_settings();
const group_group_permission_settings = new Set(settings_config.group_permission_settings);
if (
!all_group_group_settings.every((setting_name) =>
settings_config.group_permission_settings.includes(setting_name),
group_group_permission_settings.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.group_permission_settings'");
return;
}
const group_group_setting_label_object_keys = Object.keys(
settings_config.all_group_setting_labels.group,
const group_group_setting_label_object_keys = new Set(
Object.keys(settings_config.all_group_setting_labels.group),
);
if (
!all_group_group_settings.every((setting_name) =>
group_group_setting_label_object_keys.includes(setting_name),
group_group_setting_label_object_keys.has(setting_name),
)
) {
blueslip.error("Settings missing in 'settings_config.all_group_setting_labels.group'");