CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

message_viewport: Fix msg selection not updated on scroll.

Browse Source 
Reproducer:
* Mark all messages in a topic as unread.
* Go to recent view.
* Click on topic.
* Scroll
* Message selection is not updated.

To fix this, we don't disable updating message selection unless
we are sure we are going to trigger a scroll event.
This commit is contained in:
Aman Agrawal 2025-02-02 13:46:39 +05:30 committed by Tim Abbott
parent a4e8b97e28
commit bb8d0684e7
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/message_viewport.ts
View File

@ -153,6 +153,16 @@ export function set_message_position(
const new_scroll_top = message_top - message_offset;
// Ensure we will scroll before we disable updating selection.
// This avoids a bug where message selection doesn't change on user scroll.
if (
// Can't scroll up if we are already at top.
(new_scroll_top <= 0 && window.scrollY === 0) ||
// Can't scroll down if we are already at bottom.
(new_scroll_top >= height() && window.scrollY === height())
) {
return;
}
message_scroll_state.set_update_selection_on_next_scroll(false);
scrollTop(new_scroll_top);
}