From ba67a9b76a49db53e1df6f8a6475be7fe2a47469 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 2 Aug 2019 17:33:42 -0700 Subject: [PATCH] message: Use RawUnreadMessageResult typing more. This is a cleaner implementation given we have the TypedDict defined. --- zerver/lib/message.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/zerver/lib/message.py b/zerver/lib/message.py index e09ed5ed98..dc70928133 100644 --- a/zerver/lib/message.py +++ b/zerver/lib/message.py @@ -895,7 +895,7 @@ def aggregate_unread_data(raw_data: RawUnreadMessagesResult) -> UnreadMessagesRe return result def apply_unread_message_event(user_profile: UserProfile, - state: Dict[str, Any], + state: RawUnreadMessagesResult, message: Dict[str, Any], flags: List[str]) -> None: message_id = message['id'] @@ -950,13 +950,13 @@ def apply_unread_message_event(user_profile: UserProfile, if 'mentioned' in flags: state['mentions'].add(message_id) -def remove_message_id_from_unread_mgs(state: Dict[str, Any], +def remove_message_id_from_unread_mgs(state: RawUnreadMessagesResult, message_id: int) -> None: # The opposite of apply_unread_message_event; removes a read or # deleted message from a raw_unread_msgs data structure. - for key in ['pm_dict', 'stream_dict', 'huddle_dict']: - state[key].pop(message_id, None) - + state['pm_dict'].pop(message_id, None) + state['stream_dict'].pop(message_id, None) + state['huddle_dict'].pop(message_id, None) state['unmuted_stream_msgs'].discard(message_id) state['mentions'].discard(message_id)