CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-21 21:32:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

node tests: Inline setup for settings_bots.

Browse Source 
I also use override in more places, and I add
$.validator to zjquery.

In passing I clean up some IIFEs that aren't
really needed.
This commit is contained in:
Steve Howell 2021-02-22 12:10:25 +00:00 committed by Steve Howell
parent 38e3aa490f
commit b40d8d5790
2 changed files with 31 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
frontend_tests/node_tests/settings_bots.js
View File

@ -118,12 +118,10 @@ function test_create_bot_type_input_box_toggle(f) {
assert(!config_inputbox.visible());
}
function set_up() {
run_test("test tab clicks", (override) => {
$.clear_all_elements();
// bunch of stubs
$.validator = {addMethod: () => {}};
override($.validator, "addMethod", () => {});
$("#create_bot_form").validate = () => {};
@ -133,20 +131,12 @@ function set_up() {
};
return mock_children;
};
avatar.build_bot_create_widget = () => {};
avatar.build_bot_edit_widget = () => {};
override(avatar, "build_bot_create_widget", () => {});
settings_bots.set_up();
test_create_bot_type_input_box_toggle(() => $("#create_bot_type").trigger("change"));
}
run_test("set_up", () => {
set_up();
});
run_test("test tab clicks", () => {
set_up();
function click_on_tab(tab_elem) {
tab_elem.trigger("click");
@ -171,38 +161,32 @@ run_test("test tab clicks", () => {
inactive: $("#inactive_bots_list"),
};
(function () {
click_on_tab(tabs.add);
assert(tabs.add.hasClass("active"));
assert(!tabs.active.hasClass("active"));
assert(!tabs.inactive.hasClass("active"));
click_on_tab(tabs.add);
assert(tabs.add.hasClass("active"));
assert(!tabs.active.hasClass("active"));
assert(!tabs.inactive.hasClass("active"));
assert(forms.add.visible());
assert(!forms.active.visible());
assert(!forms.inactive.visible());
})();
assert(forms.add.visible());
assert(!forms.active.visible());
assert(!forms.inactive.visible());
(function () {
click_on_tab(tabs.active);
assert(!tabs.add.hasClass("active"));
assert(tabs.active.hasClass("active"));
assert(!tabs.inactive.hasClass("active"));
click_on_tab(tabs.active);
assert(!tabs.add.hasClass("active"));
assert(tabs.active.hasClass("active"));
assert(!tabs.inactive.hasClass("active"));
assert(!forms.add.visible());
assert(forms.active.visible());
assert(!forms.inactive.visible());
})();
assert(!forms.add.visible());
assert(forms.active.visible());
assert(!forms.inactive.visible());
(function () {
click_on_tab(tabs.inactive);
assert(!tabs.add.hasClass("active"));
assert(!tabs.active.hasClass("active"));
assert(tabs.inactive.hasClass("active"));
click_on_tab(tabs.inactive);
assert(!tabs.add.hasClass("active"));
assert(!tabs.active.hasClass("active"));
assert(tabs.inactive.hasClass("active"));
assert(!forms.add.visible());
assert(!forms.active.visible());
assert(forms.inactive.visible());
})();
assert(!forms.add.visible());
assert(!forms.active.visible());
assert(forms.inactive.visible());
});
run_test("can_create_new_bots", () => {

6
frontend_tests/zjsunit/zjquery.js
View File

@ -549,6 +549,12 @@ function make_zjquery() {
elems.clear();
};
zjquery.validator = {
addMethod() {
throw new Error("You must create your own $.validator.addMethod stub.");
},
};
return zjquery;
}