From b406cc84ffb099fc65c581f06fe390388893b341 Mon Sep 17 00:00:00 2001 From: N-Shar-ma Date: Fri, 31 Mar 2023 19:18:23 +0530 Subject: [PATCH] Revert "typeahead: Fix bug where typeahead showed momentarily on shift + tab." This reverts commit fa37befe3c40d256afe50e5d5137d2f5a4159214, which broke the topic typeahead after a complete stream name. --- web/third/bootstrap-typeahead/typeahead.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/web/third/bootstrap-typeahead/typeahead.js b/web/third/bootstrap-typeahead/typeahead.js index 1971b4d87a..506755b68f 100644 --- a/web/third/bootstrap-typeahead/typeahead.js +++ b/web/third/bootstrap-typeahead/typeahead.js @@ -439,6 +439,7 @@ import {get_string_diff} from "../../src/util"; , keydown: function (e) { const pseudo_keycode = get_pseudo_keycode(e); if (this.trigger_selection(e)) { + if (!this.shown) return; e.preventDefault(); this.select(e); } @@ -473,11 +474,6 @@ import {get_string_diff} from "../../src/util"; } break - // to stop typeahead from showing up momentarily - // when shift + tabbing to a field with typeahead - case 16: // shift - return - default: var hideOnEmpty = false if (e.keyCode === 8 && this.options.helpOnEmptyStrings) { // backspace