CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

makemessages: Remove vestigial custom JavaScript extraction.

Browse Source 
Commit d8a36d0702 (#18075) should have
removed this.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2025-07-28 14:27:39 -07:00 committed by Tim Abbott
parent afdf20c67e
commit b404ca1a02
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
zerver/management/commands/makemessages.py
View File

@ -33,7 +33,6 @@ https://stackoverflow.com/questions/2090717
"""
import glob
import itertools
import os
import re
import subprocess
@ -75,8 +74,6 @@ tags = [
]
frontend_compiled_regexes = [re.compile(regex) for regex in regexes]
multiline_js_comment = re.compile(r"/\*.*?\*/", re.DOTALL)
singleline_js_comment = re.compile(r"//.*?\n")
def strip_whitespaces(src: str, env: Environment) -> str:
@ -209,13 +206,6 @@ class Command(makemessages.Command):
return translation_strings
def ignore_javascript_comments(self, data: str) -> str:
# Removes multi line comments.
data = multiline_js_comment.sub("", data)
# Removes single line (//) comments.
data = singleline_js_comment.sub("", data)
return data
def get_translation_strings(self) -> list[str]:
translation_strings: list[str] = []
dirname = self.get_template_dir()
@ -227,16 +217,6 @@ class Command(makemessages.Command):
with open(os.path.join(dirpath, filename)) as reader:
data = reader.read()
translation_strings.extend(self.extract_strings(data))
for dirpath, dirnames, filenames in itertools.chain(
os.walk("web/src"), os.walk("web/shared/src")
):
for filename in [f for f in filenames if f.endswith((".js", ".ts"))]:
if filename.startswith("."):
continue
with open(os.path.join(dirpath, filename)) as reader:
data = reader.read()
data = self.ignore_javascript_comments(data)
translation_strings.extend(self.extract_strings(data))
extracted = subprocess.check_output(
[