From b2498307154430d3c84dbfcab290ca83071cfffc Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 18 Oct 2024 11:24:01 -0700 Subject: [PATCH] rocketchat: Harden parsing of custom emoji exports. Apparently some exports have a weird `ObjectId("idstring")` typed value here, that stringify to the actual string. --- zerver/data_import/rocketchat.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/data_import/rocketchat.py b/zerver/data_import/rocketchat.py index 275a08d201..dc3a91154e 100644 --- a/zerver/data_import/rocketchat.py +++ b/zerver/data_import/rocketchat.py @@ -279,7 +279,7 @@ def build_custom_emoji( # Map emoji file_id to emoji file data emoji_file_data = {} for emoji_file in custom_emoji_data["file"]: - emoji_file_data[emoji_file["_id"]] = {"filename": emoji_file["filename"], "chunks": []} + emoji_file_data[str(emoji_file["_id"])] = {"filename": emoji_file["filename"], "chunks": []} for emoji_chunk in custom_emoji_data["chunk"]: emoji_file_data[emoji_chunk["files_id"]]["chunks"].append(emoji_chunk["data"])