CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-15 21:03:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

stream-settings: Fix live updating of stream privacy options.

Browse Source 
There was a bug where the private stream options were live
updated when a user gained access to create private streams
even if the stream was set as a default stream which cannot
be changed to private.

This was because update_private_stream_privacy_option_state
used "false" as default for "is_default_stream" parameter.
This commit updates the code to compute is_default_stream
value in update_private_stream_privacy_option_state itself
to avoid any such bugs and this also helps in refactoring
in further commits.
This commit is contained in:
Sahil Batra 2025-11-06 18:38:25 +05:30 committed by Tim Abbott
parent 6150d86578
commit adeee80808
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/stream_ui_updates.ts
View File

@ -111,10 +111,7 @@ export function update_web_public_stream_privacy_option_state($container: JQuery
}
}
export function update_private_stream_privacy_option_state(
$container: JQuery,
is_default_stream = false,
): void {
export function update_private_stream_privacy_option_state($container: JQuery): void {
// Disable both "Private, shared history" and "Private, protected history" options.
const $private_stream_elem = $container.find(
`input[value='${CSS.escape(settings_config.stream_privacy_policy_values.private.code)}']`,
@ -125,6 +122,11 @@ export function update_private_stream_privacy_option_state(
)}']`,
);
// If the default stream option is checked, the private stream options are disabled.
const is_default_stream = util.the(
$container.find<HTMLInputElement>(".default-stream input"),
).checked;
const disable_private_stream_options =
is_default_stream || !settings_data.user_can_create_private_streams();
@ -313,9 +315,7 @@ export function update_default_stream_and_stream_privacy_state($container: JQuer
is_invite_only,
);
// If the default stream option is checked, the private stream options are disabled.
const is_default_stream = util.the($default_stream.find("input")).checked;
update_private_stream_privacy_option_state($container, is_default_stream);
update_private_stream_privacy_option_state($container);
}
export function update_can_subscribe_group_label($container: JQuery): void {