CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

message_edit: Attach keydown to $form instead of textarea.

Browse Source 
This allows any event handlers that are attached to textarea
like typeahead to handle the keypress and stop propagation if
they successfully handle it.

This fixes a bug where message edit form gets saved on enter keypress
instead of selecting the active item in the message edit typeahead.

Introduced in 0696e234bd.
This commit is contained in:
Aman Agrawal 2024-09-20 06:21:22 +00:00 committed by Tim Abbott
parent 18fbb5d146
commit a35c8a08de
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/composebox_typeahead.ts
View File

@ -1305,7 +1305,9 @@ export function initialize({
}: {
on_enter_send: (scheduling_message?: boolean) => boolean | undefined;
}): void {
// These handlers are at the "form" level so that they are called after typeahead
// Attach event handlers to `form` instead of `textarea` to allow
// typeahead to call stopPropagation if it can handle the event
// and prevent the form from submitting.
$("form#send_message_form").on("keydown", (e) => {
handle_keydown(e, on_enter_send);
});

5
web/src/message_edit.ts
View File

@ -508,7 +508,10 @@ function edit_message($row: JQuery, raw_content: string): void {
currently_editing_messages.set(message.id, $message_edit_content);
message_lists.current.show_edit_message($row, $form);
$message_edit_content.on("keydown", (e) => {
// Attach event handlers to `form` instead of `textarea` to allow
// typeahead to call stopPropagation if it can handle the event
// and prevent the form from submitting.
$form.on("keydown", (e) => {
if (keydown_util.is_enter_event(e)) {
handle_message_edit_enter(e, $message_edit_content);
}