From a2b7929b22f4b6e4eacf6bb2e0fb3bbf91238221 Mon Sep 17 00:00:00 2001 From: derAnfaenger Date: Thu, 12 Oct 2017 16:52:53 +0200 Subject: [PATCH] embedded bots: Alter tests to accept any class name. Some bots have class names that differ from their module name, e.g. `helloworld.py` vs. `HelloWorld`. Our tests should accept all of these, as long as a handler class is present. --- zerver/tests/test_bots.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/zerver/tests/test_bots.py b/zerver/tests/test_bots.py index 3091e99030..0a57a5924d 100644 --- a/zerver/tests/test_bots.py +++ b/zerver/tests/test_bots.py @@ -982,14 +982,8 @@ class BotTest(ZulipTestCase, UploadSerializeMixin): def test_if_each_embedded_bot_service_exists(self): # type: () -> None - # Each bot has its bot handler class name as Bot_nameHandler. For instance encrypt bot has - # its class name as EncryptHandler. - class_bot_handler = "" for embedded_bot in EMBEDDED_BOTS: - embedded_bot_handler = get_bot_handler(embedded_bot.name) - bot_name = embedded_bot.name - bot_handler_class_name = class_bot_handler.format(name=bot_name, Name=bot_name.title()) - self.assertEqual(str(type(embedded_bot_handler)), bot_handler_class_name) + self.assertIsNotNone(get_bot_handler(embedded_bot.name)) def test_outgoing_webhook_interface_type(self): # type: () -> None