Extract finish_group() helper in MessageListView.render()

(imported from commit db13ca858631d10a310aba3bd2540a545fd5b871)
This commit is contained in:
Steve Howell 2013-08-22 18:14:11 -04:00
parent 579444eee2
commit a0b28a03e4

View File

@ -149,6 +149,12 @@ MessageListView.prototype = {
prev = _.pick(prev, 'timestamp', 'historical');
}
function finish_group() {
if (current_group.length > 0) {
new_message_groups.push(current_group);
}
}
_.each(messages, function (message) {
message.include_recipient = false;
message.include_bookend = false;
@ -209,9 +215,7 @@ MessageListView.prototype = {
// prev is no longer the last element in this block
prev.include_footer = false;
} else {
if (current_group.length > 0) {
new_message_groups.push(current_group);
}
finish_group();
current_group = [message.id];
// Add a space to the table, but not for the first element.
@ -272,9 +276,7 @@ MessageListView.prototype = {
return;
}
if (current_group.length > 0) {
new_message_groups.push(current_group);
}
finish_group();
if (where === 'top') {
self._message_groups = new_message_groups.concat(self._message_groups);