From a01fcd3d94233ce673c904fb08f659dfe0e7b048 Mon Sep 17 00:00:00 2001 From: afeefuddin Date: Tue, 2 Jul 2024 02:18:21 +0530 Subject: [PATCH] user_group_components: Fix inaccurate parameter types in functions. --- web/src/user_group_components.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/web/src/user_group_components.ts b/web/src/user_group_components.ts index 8606ea6602..1fb489e49b 100644 --- a/web/src/user_group_components.ts +++ b/web/src/user_group_components.ts @@ -1,4 +1,5 @@ import $ from "jquery"; +import assert from "minimalistic-assert"; import * as dropdown_widget from "./dropdown_widget"; import {$t_html} from "./i18n"; @@ -8,13 +9,17 @@ import type {UserGroup} from "./user_groups"; export let active_group_id: number | undefined; -export function setup_permissions_dropdown(group: UserGroup, for_group_creation: boolean): void { +export function setup_permissions_dropdown( + group: UserGroup | undefined, + for_group_creation: boolean, +): void { let widget_name: string; let default_id: number; if (for_group_creation) { widget_name = "new_group_can_mention_group"; default_id = user_groups.get_user_group_from_name("role:everyone")!.id; } else { + assert(group !== undefined); widget_name = "can_mention_group"; default_id = group.can_mention_group; } @@ -32,6 +37,7 @@ export function setup_permissions_dropdown(group: UserGroup, for_group_creation: event.stopPropagation(); can_mention_group_widget.render(); if (!for_group_creation) { + assert(group !== undefined); settings_components.save_discard_group_widget_status_handler( $("#group_permission_settings"), group, @@ -82,7 +88,7 @@ export const show_user_group_settings_pane = { set_active_group_id(group.id); $("#groups_overlay .user-group-info-title").text(group.name); }, - create_user_group(container_name = "configure_user_group_settings", group_name: string) { + create_user_group(container_name = "configure_user_group_settings", group_name?: string) { $(".user_group_creation").hide(); if (container_name === "configure_user_group_settings") { $("#groups_overlay .user-group-info-title").text(