From 98ec84eae2b0d2c3ce35dbe782cd16c53818e439 Mon Sep 17 00:00:00 2001 From: Mateusz Mandera Date: Fri, 7 May 2021 15:14:24 +0200 Subject: [PATCH] tests: Change password hashers used in tests that set them. The previous hashers mirrored the ones used in production, but that was non-ideal because those are slow. Replacing them with quick hashers is a performance improvement for those tests. --- zerver/tests/test_auth_backends.py | 12 ++++++------ zerver/tests/test_signup.py | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/zerver/tests/test_auth_backends.py b/zerver/tests/test_auth_backends.py index 418dd7d793..733ceb91a5 100644 --- a/zerver/tests/test_auth_backends.py +++ b/zerver/tests/test_auth_backends.py @@ -346,14 +346,14 @@ class AuthBackendTest(ZulipTestCase): user_profile = self.example_user("hamlet") password = "a_password_of_22_chars" - with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.PBKDF2PasswordHasher",)): + with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.SHA1PasswordHasher",)): user_profile.set_password(password) user_profile.save() with self.settings( PASSWORD_HASHERS=( - "django.contrib.auth.hashers.Argon2PasswordHasher", - "django.contrib.auth.hashers.PBKDF2PasswordHasher", + "django.contrib.auth.hashers.MD5PasswordHasher", + "django.contrib.auth.hashers.SHA1PasswordHasher", ), PASSWORD_MIN_LENGTH=30, ), self.assertLogs("zulip.auth.email", level="INFO"), self.assertRaises(JsonableError) as m: @@ -3935,14 +3935,14 @@ class FetchAPIKeyTest(ZulipTestCase): user_profile = self.example_user("hamlet") password = "a_password_of_22_chars" - with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.PBKDF2PasswordHasher",)): + with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.SHA1PasswordHasher",)): user_profile.set_password(password) user_profile.save() with self.settings( PASSWORD_HASHERS=( - "django.contrib.auth.hashers.Argon2PasswordHasher", - "django.contrib.auth.hashers.PBKDF2PasswordHasher", + "django.contrib.auth.hashers.MD5PasswordHasher", + "django.contrib.auth.hashers.SHA1PasswordHasher", ), PASSWORD_MIN_LENGTH=30, ), self.assertLogs("zulip.auth.email", level="INFO"): diff --git a/zerver/tests/test_signup.py b/zerver/tests/test_signup.py index acbadc6ad1..9345d2610d 100644 --- a/zerver/tests/test_signup.py +++ b/zerver/tests/test_signup.py @@ -710,14 +710,14 @@ class LoginTest(ZulipTestCase): user_profile = self.example_user("hamlet") password = "a_password_of_22_chars" - with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.PBKDF2PasswordHasher",)): + with self.settings(PASSWORD_HASHERS=("django.contrib.auth.hashers.SHA1PasswordHasher",)): user_profile.set_password(password) user_profile.save() with self.settings( PASSWORD_HASHERS=( - "django.contrib.auth.hashers.Argon2PasswordHasher", - "django.contrib.auth.hashers.PBKDF2PasswordHasher", + "django.contrib.auth.hashers.MD5PasswordHasher", + "django.contrib.auth.hashers.SHA1PasswordHasher", ), PASSWORD_MIN_LENGTH=30, ), self.assertLogs("zulip.auth.email", level="INFO"):