CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-21 21:32:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

invite: Fix text of submit-invitation button on completion.

Browse Source 
There is a bug in invite flow, where the button text resets
to incorrect text after the invitation process is completed.
This bug is because we are using $().button("reset") to
reset the button text, but the data-reset-text attribute of
button is not changed when toggling between multi-use link
invite and email invites.

This bug can be fixed by setting data-reset-text attribute
in a way similar to the way we set data-loading-text attribute
on toggling between multiuse and normal invites.

But according to the bootstrap docs,"reset" method was removed
in v4.0 (https://getbootstrap.com/docs/4.0/migration/#buttons).

Though we are not using Bootstrap v4.0 as of now, but it is
good to remove such methods as it will help in future when we
would upgrade to later bootstrap versions.

So instead of fixing this by above mentioned patch, we are
fixing this by removing "reset" method and instead using simple
jquery to reset the text and enable the button after the invite
process is completed.
This commit is contained in:
sahil839 2020-09-28 17:26:37 +05:30 committed by Tim Abbott
parent c199571112
commit 8f736e6917
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/invite.js
View File

@ -98,7 +98,8 @@ function submit_invitation_form() {
}
},
complete() {
$("#submit-invitation").button("reset");
$("#submit-invitation").text(i18n.t("Invite"));
$("#submit-invitation").prop("disabled", false);
$("#invitee_emails").focus();
ui.get_scroll_element($("#invite_user_form .modal-body"))[0].scrollTop = 0;
},
@ -124,7 +125,8 @@ function generate_multiuse_invite() {
ui_report.error("", xhr, invite_status);
},
complete() {
$("#submit-invitation").button("reset");
$("#submit-invitation").text(i18n.t("Generate invite link"));
$("#submit-invitation").prop("disabled", false);
},
});
}