CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

user_groups: Extract check_user_group_can_be_deactivated helper.

Browse Source
This commit is contained in:
Mateusz Mandera 2025-04-25 01:16:35 +08:00 committed by Tim Abbott
parent 8f66e0b640
commit 88d1dcaf02
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
zerver/lib/user_groups.py
View File

@ -192,17 +192,7 @@ def access_user_group_for_update(
raise JsonableError(_("Insufficient permission"))
def access_user_group_for_deactivation(
user_group_id: int, user_profile: UserProfile
) -> NamedUserGroup:
"""
Main security check / access function for whether the acting
user has permission to deactivate a given user group.
"""
user_group = access_user_group_for_update(
user_group_id, user_profile, permission_setting="can_manage_group"
)
def check_user_group_can_be_deactivated(user_group: NamedUserGroup) -> list[dict[str, Any]]:
objections: list[dict[str, Any]] = []
supergroup_ids = (
user_group.direct_supergroups.exclude(named_user_group=None)
@ -275,6 +265,20 @@ def access_user_group_for_deactivation(
if objection_settings:
objections.append(dict(type="realm", settings=objection_settings))
return objections
def access_user_group_for_deactivation(
user_group_id: int, user_profile: UserProfile
) -> NamedUserGroup:
"""
Main security check / access function for whether the acting
user has permission to deactivate a given user group.
"""
user_group = access_user_group_for_update(
user_group_id, user_profile, permission_setting="can_manage_group"
)
objections = check_user_group_can_be_deactivated(user_group)
if len(objections) > 0:
raise CannotDeactivateGroupInUseError(objections)
return user_group