From 8778e5039bb2fe5188220855ae4e125e4e665091 Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Wed, 24 Nov 2021 19:17:25 +0530 Subject: [PATCH] stream_settings: Refactor code to disable public stream privacy option. This commit renames disable_public_stream_privacy_option to update_public_stream_privacy_option_state and also refactors the code such that it can also be used to enable the option along with disabling the option in further commit. --- static/js/stream_settings_ui.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/static/js/stream_settings_ui.js b/static/js/stream_settings_ui.js index 95563e6d2f..3332cf1b35 100644 --- a/static/js/stream_settings_ui.js +++ b/static/js/stream_settings_ui.js @@ -1014,11 +1014,11 @@ export function update_web_public_stream_privacy_option_state(container) { } } -export function disable_public_stream_privacy_option(container) { +export function update_public_stream_privacy_option_state(container) { const public_stream_elem = container.find( `input[value='${CSS.escape(stream_data.stream_privacy_policy_values.public.code)}']`, ); - public_stream_elem.prop("disabled", true); + public_stream_elem.prop("disabled", !settings_data.user_can_create_public_streams()); } export function disable_private_stream_privacy_option(container) { @@ -1039,9 +1039,7 @@ export function disable_private_stream_privacy_option(container) { export function hide_or_disable_stream_privacy_options_if_required(container) { update_web_public_stream_privacy_option_state(container); - if (!settings_data.user_can_create_public_streams()) { - disable_public_stream_privacy_option(container); - } + update_public_stream_privacy_option_state(container); if (!settings_data.user_can_create_private_streams()) { disable_private_stream_privacy_option(container);