From 872e2ad2cd52ca2cb09e8fc4dc0fb91e85514484 Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Tue, 25 Jun 2024 21:34:44 +0000 Subject: [PATCH] models: Enforce an ordering to on audit logs to solve a flaky test. Multiple events may be created with the same timestamp; we add a default ordering by "id" such that these have a consistent ordering in tests (to solve for flaky tests), as well as in the internal API. --- zerver/models/realm_audit_logs.py | 1 + 1 file changed, 1 insertion(+) diff --git a/zerver/models/realm_audit_logs.py b/zerver/models/realm_audit_logs.py index 32c010cee2..11464c2e5e 100644 --- a/zerver/models/realm_audit_logs.py +++ b/zerver/models/realm_audit_logs.py @@ -226,6 +226,7 @@ class RealmAuditLog(AbstractRealmAuditLog): event_last_message_id = models.IntegerField(null=True) class Meta: + ordering = ["id"] indexes = [ models.Index( name="zerver_realmauditlog_realm__event_type__event_time",