CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

stream edit: Find stuff within parent_container.

Browse Source 
This will facilitate code reuse.
This commit is contained in:
Steve Howell 2021-12-15 19:12:45 +00:00 committed by Tim Abbott
parent 2194a51b97
commit 7f8ea5b9f2
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/stream_edit.js
View File

@ -151,6 +151,12 @@ test_ui("subscriber_pills", ({override, mock_template}) => {
case ".pill-container": {
return pill_container_stub;
}
case ".subscriber_table": {
return $.create("subscriber-table-stub");
}
case ".subscriber_list_container": {
return undefined;
}
// No default
}
throw new Error(`unexpected selector ${selector}`);

19
static/js/stream_edit.js
View File

@ -185,13 +185,6 @@ function format_member_list_elem(person) {
});
}
function get_subscriber_list(sub_row) {
const stream_id_str = sub_row.data("stream-id");
return $(
`.subscription_settings[data-stream-id="${CSS.escape(stream_id_str)}"] .subscriber_table`,
);
}
export function update_stream_name(sub, new_name) {
const edit_container = stream_settings_containers.get_edit_container(sub);
edit_container.find(".email-address").text(sub.email_address);
@ -392,9 +385,6 @@ function enable_subscriber_management({sub, parent_container}) {
if (!stream_data.can_toggle_subscription(sub)) {
stream_ui_updates.initialize_cant_subscribe_popover(sub);
}
// fetch subscriber list from memory.
const list = get_subscriber_list(parent_container);
list.empty();
const user_ids = peer_data.get_subscribers(stream_id);
const users = people.get_users_from_ids(user_ids);
@ -405,7 +395,12 @@ function enable_subscriber_management({sub, parent_container}) {
return user_pill.filter_taken_users(potential_subscribers, pill_widget);
}
ListWidget.create(list, users, {
const list_container = parent_container.find(".subscriber_table");
list_container.empty();
const simplebar_container = parent_container.find(".subscriber_list_container");
ListWidget.create(list_container, users, {
name: "stream_subscribers/" + stream_id,
modifier(item) {
return format_member_list_elem(item);
@ -419,7 +414,7 @@ function enable_subscriber_management({sub, parent_container}) {
return match;
},
},
simplebar_container: $(".subscriber_list_container"),
simplebar_container,
});
const opts = {