From 7eec8fe3a22e7828ead3933c8ade84705a35c525 Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <anders@zulip.com>
Date: Mon, 26 May 2025 15:29:49 -0700
Subject: [PATCH] popover_menus: Allow focusing an item when none is focused.

Commit 71fbc93c035df262d29607b3786bbfd2eeb402d8 (#34685) incorrectly
removed this behavior.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
---
 web/src/popover_menus.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/src/popover_menus.ts b/web/src/popover_menus.ts
index 8dae6009ad..5671024a05 100644
--- a/web/src/popover_menus.ts
+++ b/web/src/popover_menus.ts
@@ -77,14 +77,14 @@ export function popover_items_handle_keyboard(key: string, $items?: JQuery): voi
         return;
     }
 
-    if ((key === "down_arrow" || key === "vim_down") && index !== -1) {
+    if (key === "down_arrow" || key === "vim_down") {
         [...$items]
-            .slice(index + 1)
+            .slice(index === -1 ? 0 : index + 1)
             .find((item) => item.getClientRects().length)
             ?.focus();
-    } else if ((key === "up_arrow" || key === "vim_up") && index !== -1) {
+    } else if (key === "up_arrow" || key === "vim_up") {
         [...$items]
-            .slice(0, index)
+            .slice(0, index === -1 ? $items.length : index)
             .findLast((item) => item.getClientRects().length)
             ?.focus();
     }