CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-06 21:18:58 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

stream_ui_updates: Extract update_subscribers_count function.

Browse Source
This commit is contained in:
Yashashvi Dave 2019-05-03 10:54:07 +05:30 committed by Tim Abbott
parent 4cd33f23bc
commit 7d7cf3d786
2 changed files with 21 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
static/js/stream_ui_updates.js
View File

@ -89,8 +89,6 @@ exports.update_stream_privacy_type_icon = function (sub) {
}
};
exports.update_stream_privacy_type_text = function (sub) {
var stream_settings = stream_edit.settings_for_sub(sub);
var html = templates.render('subscription_type', sub);
@ -99,6 +97,20 @@ exports.update_stream_privacy_type_text = function (sub) {
}
};
exports.update_subscribers_count = function (sub, just_subscribed) {
if (!overlays.streams_open()) {
// If the streams overlay isn't open, we don't need to rerender anything.
return;
}
var stream_row = subs.row_for_stream_id(sub.stream_id);
if (!sub.can_access_subscribers || just_subscribed && sub.invite_only) {
var rendered_sub_count = templates.render("subscription_count", sub);
stream_row.find('.subscriber-count').expectOne().html(rendered_sub_count);
} else {
stream_row.find(".subscriber-count-text").expectOne().text(sub.subscriber_count);
}
};
return exports;
}());

31
static/js/subs.js
View File

@ -162,21 +162,6 @@ exports.set_color = function (stream_id, color) {
stream_edit.set_stream_property(sub, 'color', color);
};
exports.rerender_subscribers_count = function (sub, just_subscribed) {
if (!overlays.streams_open()) {
// If the streams overlay isn't open, we don't need to rerender anything.
return;
}
var stream_row = exports.row_for_stream_id(sub.stream_id);
stream_data.update_subscribers_count(sub);
if (!sub.can_access_subscribers || just_subscribed && sub.invite_only) {
var rendered_sub_count = templates.render("subscription_count", sub);
stream_row.find('.subscriber-count').expectOne().html(rendered_sub_count);
} else {
stream_row.find(".subscriber-count-text").expectOne().text(sub.subscriber_count);
}
};
exports.rerender_subscriptions_settings = function (sub) {
// This rerendes the subscriber data for a given sub object
// where it might have already been rendered in the subscriptions UI.
@ -184,14 +169,11 @@ exports.rerender_subscriptions_settings = function (sub) {
blueslip.error('Undefined sub passed to function rerender_subscriptions_settings');
return;
}
if (overlays.streams_open()) {
// Render subscriptions templates only if subscription tab is open
exports.rerender_subscribers_count(sub);
if (stream_edit.is_sub_settings_active(sub)) {
// Render subscriptions only if stream settings is open
stream_edit.rerender_subscribers_list(sub);
}
stream_data.update_subscribers_count(sub);
stream_ui_updates.update_subscribers_count(sub);
if (stream_edit.is_sub_settings_active(sub)) {
// Render subscriptions only if stream settings is open
stream_edit.rerender_subscribers_list(sub);
}
};
@ -274,8 +256,9 @@ exports.update_settings_for_subscribed = function (sub) {
$(".subscription_settings[data-stream-id='" + sub.stream_id + "'] #preview-stream-button").show();
if (exports.is_sub_already_present(sub)) {
stream_data.update_subscribers_count(sub);
stream_ui_updates.update_stream_row_in_settings_tab(sub);
exports.rerender_subscribers_count(sub, true);
stream_ui_updates.update_subscribers_count(sub, true);
stream_ui_updates.update_check_button_for_sub(sub);
stream_ui_updates.update_settings_button_for_sub(sub);
stream_ui_updates.update_change_stream_privacy_settings(sub);