CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-15 21:03:26 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

export: Refuse to overwrite an existing directory or tarball.

Browse Source 
Previously, incorrectly passing an existing directory to the
`manage.py export --output` option would remove its contents without
warning.  Abort instead.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2019-09-12 14:36:45 -07:00 committed by Tim Abbott
parent fcf5936341
commit 78b018989e
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
zerver/management/commands/export.py
View File

@ -1,6 +1,5 @@
import os
import tempfile
import shutil
from argparse import ArgumentParser
from typing import Any
@ -118,9 +117,21 @@ class Command(ZulipBaseCommand):
output_dir = tempfile.mkdtemp(prefix="zulip-export-")
else:
output_dir = os.path.realpath(os.path.expanduser(output_dir))
if os.path.exists(output_dir):
shutil.rmtree(output_dir)
os.makedirs(output_dir)
if os.path.exists(output_dir):
if os.listdir(output_dir):
raise CommandError(
"Refusing to overwrite nonempty directory: %s. Aborting..."
% (output_dir,)
)
else:
os.makedirs(output_dir)
tarball_path = output_dir.rstrip("/") + ".tar.gz"
try:
os.close(os.open(tarball_path, os.O_CREAT | os.O_EXCL | os.O_WRONLY, 0o666))
except FileExistsError:
raise CommandError("Refusing to overwrite existing tarball: %s. Aborting..." % (tarball_path,))
print("\033[94mExporting realm\033[0m: %s" % (realm.string_id,))
num_threads = int(options['threads'])