From 75126c96a4046866140f85efe268d36cb11889bd Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Thu, 17 Aug 2023 17:11:16 +0530
Subject: [PATCH] settings: Make custom profile fields table similar to other
 tables.

This commit updates the admin custom profile fields table to be
similar to other tables in settings page. After this change,
the table will be horizontally scrollable for narrow screens
and the buttons in actions column will not wrap to multiple lines.

This increases the width of "Actions" column and it takes some
unnecessary space, but this will be handled in the next commit
which will adjust "Actions" column in all the tables.
---
 web/styles/settings.css                                 | 6 ------
 web/templates/settings/admin_profile_field_list.hbs     | 2 +-
 web/templates/settings/profile_field_settings_admin.hbs | 2 +-
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/web/styles/settings.css b/web/styles/settings.css
index 5d310806ce..c1640597f9 100644
--- a/web/styles/settings.css
+++ b/web/styles/settings.css
@@ -218,12 +218,6 @@ h3,
     & table + .progressive-table-wrapper table tr.user_row td:first-of-type {
         width: 20%;
     }
-
-    /* Limit the actions column to not using excessive width */
-    .admin-table-wrapper table.admin_profile_fields_table tr .actions {
-        width: 11%;
-        min-width: 70px;
-    }
 }
 
 #uploaded_files_table > tr > td:nth-of-type(1),
diff --git a/web/templates/settings/admin_profile_field_list.hbs b/web/templates/settings/admin_profile_field_list.hbs
index 1cf9d0e9d7..24c424e062 100644
--- a/web/templates/settings/admin_profile_field_list.hbs
+++ b/web/templates/settings/admin_profile_field_list.hbs
@@ -24,7 +24,7 @@
         {{/if}}
     </td>
     {{#if ../can_modify}}
-    <td>
+    <td class="actions">
         <button class="button rounded small btn-warning open-edit-form-modal" title="{{t 'Edit' }}" data-profile-field-id="{{id}}">
             <i class="fa fa-pencil" aria-hidden="true"></i>
         </button>
diff --git a/web/templates/settings/profile_field_settings_admin.hbs b/web/templates/settings/profile_field_settings_admin.hbs
index 5c74ac1074..e849bdb803 100644
--- a/web/templates/settings/profile_field_settings_admin.hbs
+++ b/web/templates/settings/profile_field_settings_admin.hbs
@@ -6,7 +6,7 @@
         <button class="button rounded sea-green" id="add-custom-profile-field-btn">{{t "Add a new profile field" }}</button>
         {{/if}}
     </div>
-    <div class="admin-table-wrapper">
+    <div class="admin-table-wrapper" data-simplebar>
         <table class="table table-striped admin_profile_fields_table">
             <thead>
                 <tr>