CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

user groups: Update handling of user group add event.

Browse Source 
Group list data in group_list_widget was not updated correctly,
on user group event as a result the group items shown on the
left panel were some times not according to the filters and selected
tab.
We make changes to appropriately update group list data of
group_list_widget on group add event and show group settings for
newly created group even in cases when the newely created group row
is not present in the left panel due to search filter or tab toggles.
This commit is contained in:
m-e-l-u-h-a-n 2023-05-12 22:34:52 +05:30 committed by Tim Abbott
parent 5cb99ad8a4
commit 74bcfa5a9f
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
web/src/user_group_edit.js
View File

@ -128,8 +128,7 @@ export function update_settings_pane(group) {
$edit_container.find(".group-description").text(group.description);
}
export function show_settings_for(node) {
const group = get_user_group_for_target(node);
export function show_settings_for(group) {
const html = render_user_group_settings({
group,
can_edit: can_edit(group.id),
@ -146,7 +145,7 @@ export function show_settings_for(node) {
show_membership_settings(group);
}
export function setup_group_settings(node) {
export function setup_group_settings(group) {
toggler = components.toggle({
child_wants_focus: true,
values: [
@ -160,7 +159,7 @@ export function setup_group_settings(node) {
},
});
show_settings_for(node);
show_settings_for(group);
}
export function setup_group_list_tab_hash(tab_key_value) {
@ -209,14 +208,17 @@ export function handle_deleted_group(group_id) {
user_group_settings_ui.redraw_user_group_list();
}
export function open_group_edit_panel_for_row(group_row) {
const group = get_user_group_for_target(group_row);
export function show_group_settings(group) {
$(".group-row.active").removeClass("active");
user_group_settings_ui.show_user_group_settings_pane.settings(group);
$(group_row).addClass("active");
user_group_settings_ui.row_for_group_id(group.id).addClass("active");
setup_group_edit_hash(group);
setup_group_settings(group_row);
setup_group_settings(group);
}
export function open_group_edit_panel_for_row(group_row) {
const group = get_user_group_for_target(group_row);
show_group_settings(group);
}
export function initialize() {

5
web/src/user_groups_settings_ui.js
View File

@ -129,19 +129,18 @@ export function add_group_to_table(group) {
can_edit: user_group_edit.can_edit(group.id),
});
group_list_widget.replace_list_data(user_groups.get_realm_user_groups());
redraw_user_group_list();
scroll_util
.get_content_element($("#groups_overlay_container .settings"))
.append($(settings_html));
// TODO: Address issue for visibility of newely created group.
if (user_group_create.get_name() === group.name) {
// This `user_group_create.get_name()` check tells us whether the
// group was just created in this browser window; it's a hack
// to work around the server_events code flow not having a
// good way to associate with this request because the group
// ID isn't known yet.
row_for_group_id(group.id).trigger("click");
user_group_edit.show_group_settings(group);
user_group_create.reset_name();
}
}