CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

user_card_popover: Enable keyboard nav for custom field copy buttons.

Browse Source
This commit is contained in:
Sayam Samal 2024-07-10 00:33:47 +05:30 committed by Tim Abbott
parent 8ead2035bf
commit 7232ff68f8
3 changed files with 27 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/user_card_popover.js
View File

@ -754,7 +754,7 @@ function register_click_handlers() {
user_profile.show_user_profile(user, "manage-profile-tab");
});
new ClipboardJS(".copy-custom-field-url", {
new ClipboardJS(".copy-custom-profile-field-link", {
text(trigger) {
return $(trigger).parent().find(".custom-profile-field-link").attr("href");
},

47
web/styles/popovers.css
View File

@ -159,10 +159,6 @@
text-decoration: underline;
}
}
~ i {
margin-left: auto;
}
}
.custom-user-url-field {
@ -992,31 +988,34 @@ ul.popover-group-menu-member-list {
white-space: nowrap;
overflow: hidden;
}
}
#popover-menu-copy-email {
display: flex;
padding: 3px 2px 1px;
border-radius: 4px;
color: var(--color-text-item);
text-decoration: none;
#popover-menu-copy-email,
.copy-custom-profile-field-link {
display: flex;
padding: 3px 2px 1px;
border-radius: 4px;
color: var(--color-text-item);
text-decoration: none !important;
margin-left: auto;
&.hide_copy_icon {
display: none;
}
&.hide_copy_icon {
display: none;
}
&:hover {
color: var(--color-copy-btn-hover);
background-color: var(--color-copy-btn-bg-hover);
}
&:hover {
color: var(--color-copy-btn-hover) !important;
background-color: var(--color-copy-btn-bg-hover);
}
&:active {
color: var(--color-copy-btn-active);
background-color: var(--color-copy-btn-bg-active);
}
&:active {
color: var(--color-copy-btn-active) !important;
background-color: var(--color-copy-btn-bg-active);
}
&:focus-visible {
outline-offset: 0;
}
&:focus-visible {
outline-offset: 0;
color: unset;
}
}

4
web/templates/popovers/user_card/user_card_popover_custom_fields.hbs
View File

@ -4,7 +4,9 @@
<a href="{{this.value}}" target="_blank" rel="noopener noreferrer" class="custom-profile-field-value custom-profile-field-link tippy-zulip-tooltip" data-tippy-content="{{this.name}}" tabindex="0">
<span class="custom-profile-field-text">{{this.value}}</span>
</a>
<i class="popover-menu-icon zulip-icon zulip-icon-copy tippy-zulip-tooltip copy-custom-field-url" data-tippy-content="{{t 'Copy URL' }}"></i>
<a role="menuitem" tabindex="0" class="popover-menu-link copy-custom-profile-field-link tippy-zulip-tooltip" aria-label="{{t 'Copy URL' }}" data-tippy-content="{{t 'Copy URL' }}">
<i class="popover-menu-icon zulip-icon zulip-icon-copy" aria-hidden="true"></i>
</a>
{{else if this.is_external_account}}
<a href="{{this.link}}" target="_blank" rel="noopener noreferrer" class="custom-profile-field-value custom-profile-field-link tippy-zulip-tooltip" data-tippy-content="{{this.name}}" tabindex="0">
{{#if (eq this.subtype "github") }}