CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

popover_menus: Avoid jQuery sizzle extension :visible.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2025-05-20 15:43:31 -07:00 committed by Tim Abbott
parent 42b05fdd5f
commit 71fbc93c03
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
web/src/popover_menus.ts
View File

@ -66,9 +66,9 @@ export function popover_items_handle_keyboard(key: string, $items?: JQuery): voi
return;
}
let index = $items.index($items.filter(":focus"));
const index = $items.index($items.filter(":focus"));
if (key === "enter" && index >= 0 && index < $items.length) {
if (key === "enter") {
// This is not enough for some elements which need to trigger
// natural click for them to work like ClipboardJS and follow
// the link for anchor tags. For those elements, we need to
@ -77,14 +77,17 @@ export function popover_items_handle_keyboard(key: string, $items?: JQuery): voi
return;
}
if (index === -1) {
index = 0;
} else if ((key === "down_arrow" || key === "vim_down") && index < $items.length - 1) {
index += 1;
} else if ((key === "up_arrow" || key === "vim_up") && index > 0) {
index -= 1;
if ((key === "down_arrow" || key === "vim_down") && index !== -1) {
[...$items]
.slice(index + 1)
.find((item) => item.getClientRects().length)
?.focus();
} else if ((key === "up_arrow" || key === "vim_up") && index !== -1) {
[...$items]
.slice(0, index)
.findLast((item) => item.getClientRects().length)
?.focus();
}
$items.eq(index).trigger("focus");
}
export function focus_first_popover_item($items: JQuery | undefined, index = 0): void {
@ -173,8 +176,7 @@ export function get_popover_items_for_instance(instance: tippy.Instance): JQuery
return undefined;
}
// eslint-disable-next-line no-jquery/no-sizzle
return $current_elem.find("a, [tabindex='0']").filter(":visible");
return $current_elem.find("a, [tabindex='0']");
}
export function hide_current_popover_if_visible(instance: tippy.Instance | null): void {