From 71a5d46de2f007fa538dc90bfbeee8c30acb15ac Mon Sep 17 00:00:00 2001
From: evykassirer <evy@zulip.com>
Date: Thu, 16 May 2024 16:47:08 -0700
Subject: [PATCH] typeahead_helper: Clean up current_stream check.

Followup for
https://github.com/zulip/zulip/pull/29650/files#r1569209419
---
 web/src/typeahead_helper.ts | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/web/src/typeahead_helper.ts b/web/src/typeahead_helper.ts
index 8bd42e84c3..57cd457cf6 100644
--- a/web/src/typeahead_helper.ts
+++ b/web/src/typeahead_helper.ts
@@ -311,11 +311,9 @@ export function sort_people_for_relevance<UserType extends UserOrMentionPillData
     current_topic?: string,
 ): UserType[] {
     // If sorting for recipientbox typeahead and not viewing a stream / topic, then current_stream = ""
-    let current_stream = null;
-    if (current_stream_id) {
-        current_stream = stream_data.get_sub_by_id(current_stream_id);
-    }
-    if (!current_stream) {
+    const current_stream =
+        current_stream_id !== undefined ? stream_data.get_sub_by_id(current_stream_id) : undefined;
+    if (current_stream === undefined) {
         objs.sort((person_a, person_b) => compare_people_for_relevance(person_a, person_b));
     } else {
         assert(current_stream_id !== undefined);