From 718018bbf69dc4a400dd9851762abff2aaad69bd Mon Sep 17 00:00:00 2001 From: Keegan McAllister Date: Tue, 23 Oct 2012 19:34:54 -0400 Subject: [PATCH] select_message_by_id: Fix return value when already selected (imported from commit c86509f6cf040d6acb771764d7fe2b40afa72fe3) --- zephyr/static/js/zephyr.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zephyr/static/js/zephyr.js b/zephyr/static/js/zephyr.js index 22678fb23b..462c555acd 100644 --- a/zephyr/static/js/zephyr.js +++ b/zephyr/static/js/zephyr.js @@ -195,7 +195,8 @@ function respond_to_message(reply_type) { function select_message_by_id(message_id, opts) { opts = $.extend({}, {then_scroll: false, update_server: true}, opts); if (message_id === selected_message_id && ! opts.then_scroll) { - return; + // We are already successful without doing anything! + return true; } return select_message(rows.get(message_id), opts); }